drivers/staging/vme

linux

ええと Joe Perches さん方式で以下。

$ find drivers/staging/vme -name "*.[ch]"|xargs ./scripts/checkpatch.pl \
-f --terse --nosummary|cut -f3- -d":"|sort |uniq -c|sort -n
      1  ERROR: trailing whitespace
      2  WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
      5  WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
      7  WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
      9  WARNING: quoted string split across lines
     13  WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
$

Now checkpath clean. って言えるかな。

commit するんですが

以下かな。てここで下書きするな、という話なんですがorz

staging/vme: fix checkpatch warnings

Now checkpatch clean.

      1  ERROR: trailing whitespace
      2  WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
      5  WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
      7  WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
      9  WARNING: quoted string split across lines
     13  WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...

Signed-off-by: (ry

みたいなカンジで。

とりあえず

別な branch 作ったんですが make 対象になっていないファイルがあるな。とりあえずスルーってことでこのまんま patch 送付します。

つうか

こんなカンジなんだけどどうしたものか。

$ ./scripts/get_maintainer.pl -f drivers/staging/vme/devices/vme_user.c 
Martyn Welch <martyn.welch@ge.com> (maintainer:VME SUBSYSTEM)
Manohar Vanga <manohar.vanga@gmail.com> (maintainer:VME SUBSYSTEM,commit_signer:5/9=56%)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:VME SUBSYSTEM,commit_signer:9/9=100%)
"Emilio G. Cota" <cota@braap.org> (commit_signer:4/9=44%)
Duan Jiong <djduanjiong@gmail.com> (commit_signer:1/9=11%)
Santosh Nayak <santoshprasadnayak@gmail.com> (commit_signer:1/9=11%)
devel@driverdev.osuosl.org (open list:VME SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)
$ ./scripts/get_maintainer.pl -f drivers/staging/vme/devices/vme_pio2_core.c 
Martyn Welch <martyn.welch@ge.com> (maintainer:VME SUBSYSTEM,commit_signer:2/4=50%)
Manohar Vanga <manohar.vanga@gmail.com> (maintainer:VME SUBSYSTEM)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:VME SUBSYSTEM,commit_signer:4/4=100%)
Marcos Paulo de Souza <marcos.souza.org@gmail.com> (commit_signer:1/4=25%)
Gerard Snitselaar <dev@snitselaar.org> (commit_signer:1/4=25%)
devel@driverdev.osuosl.org (open list:VME SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)
$

最大公約数で良いのかどうか。ということは

  • Martyn Welch (maintainer:VME SUBSYSTEM)
  • Manohar Vanga (maintainer:VME SUBSYSTEM,commit_signer:5/9=56%)
  • Greg Kroah-Hartman (maintainer:VME SUBSYSTEM,commit_signer:9/9=100%)
  • devel@driverdev.osuosl.org (open list:VME SUBSYSTEM)
  • linux-kernel@vger.kernel.org (open list)

てカンジなのかな。

あ

commit なナニが微妙な事が発覚orz
以下で。

staging/vme: fix checkpatch warnings

Now checkpatch clean.

$ find drivers/staging/vme -name "*.[ch]"|xargs ./scripts/checkpatch.pl \
-f --terse --nosummary|cut -f3- -d":"|sort |uniq -c|sort -n
      1  ERROR: trailing whitespace
      2  WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
      5  WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
      7  WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
      9  WARNING: quoted string split across lines
     13  WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...

Signed-off-by: (ry

修正したので

送付します。