パッチ修行

linux

昨日のパッチはステて作り直すことに。コミットは纏めてログは以下な感じになる方向。

staging/cptm1217: fix checkpatch warnings

The below checkpatch warns was fixed,

drivers/staging/cptm1217/clearpad_tm1217.c:400: WARNING: quoted string split across lines
drivers/staging/cptm1217/cp_tm1217.h:5: ERROR: open brace '{' following struct go on the same line

Signed-off-by:

とりあえず

この後、買い物に付きあわないといけないらしい。人が沢山居るところに行きたくないなぁ。

その後

patch 作って投げたら typo の指摘が入りリプライ入れたところです。ちなみに cptm1217 な TODO は以下の記述になってて

- Wait for the official upstream general clearpad drivers as promised over
  the past few months
- Merge any device support needed from this driver into it
- Delete this driver

スルーの可能性は非常に高いのではないかと。

次

et131x がターゲットになりました。要修正なナニは以下らしいんですが

$ find drivers/staging/et131x/ -name "*.[ch]"|xargs ./scripts/checkpatch.pl --file --terse
drivers/staging/et131x/et131x.c:89: WARNING: quoted string split across lines
drivers/staging/et131x/et131x.c:2557: WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
drivers/staging/et131x/et131x.c:2578: WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
drivers/staging/et131x/et131x.c:2972: WARNING: suspect code indent for conditional statements (8, 8)
drivers/staging/et131x/et131x.c:4330: WARNING: quoted string split across lines
drivers/staging/et131x/et131x.c:5192: WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
total: 0 errors, 6 warnings, 5471 lines checked
$

5192 とかどんな規模なのか。ってかそもそもこれは何なのか、と言いつつ README 見てみたら NIC なドライバらしい。

$ cat README 
This is a driver for the ET1310 network device.

Based on the driver found at https://sourceforge.net/projects/et131x/

Cleaned up immensely by Olaf Hartman and Christoph Hellwig <hch@infradead.org>

Note, the powermanagement options were removed from the vendor provided
driver as they did not build properly at the time.

TODO:
        - Use of kmem_cache seems a bit unusual

Please send patches to:
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
        Mark Einon <mark.einon@gmail.com>

とりあえず patch 作って寝かせよう。さっき修正作って云々した中で、format-patch なソレをを master に巻き戻して作った branch に apply したら、commit なログはやり直しができることが分かったので、ちょっと気が楽に。