suspect code indent for conditional statements
よく分からんかったのでメモ。この warning は if とかの開きブレイスが改行されて記述されているようなケイスで出る模様。
- if (ring_index != 1 || buff_index > rx_local->fbr[0]->num_entries - 1) + if (ring_index != 1 || buff_index > rx_local->fbr[0]->num_entries - 1) { #endif - {
コミットメセジ検討
staging/et131x: fix checkpatch warnings The below checkpatch warns was fixed, drivers/staging/et131x/et131x.c:89: WARNING: quoted string split across lines drivers/staging/et131x/et131x.c:2557: WARNING: Prefer pr_info(... to printk(KERN_INFO, ... drivers/staging/et131x/et131x.c:2578: WARNING: Prefer pr_info(... to printk(KERN_INFO, ... drivers/staging/et131x/et131x.c:2972: WARNING: suspect code indent for conditional statements (8, 8) drivers/staging/et131x/et131x.c:4330: WARNING: quoted string split across lines drivers/staging/et131x/et131x.c:5192: WARNING: Prefer pr_info(... to printk(KERN_INFO, ... And added pr_fmt. Signed-off-by:
この書き方、楽だなw
とりあえず commit を作って Lions' 方面に。